ci(sweeper): continue execution when resources cannot be deleted #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remyleone
approved these changes
Jul 16, 2025
remyleone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many CLI tests are failing because they exceed Scaleway quotas. The issue is that the sweeper stops execution immediately when it encounters block volume deletion failures (e.g., volumes in in_use status), leaving other resources undeleted. This causes resource accumulation across test runs, leading to quota exhaustion and test failures. The fix modifies the sweeper to continue execution on individual resource failures, collect all errors, and only exit with a fatal error after attempting to clean all resources. This ensures maximum cleanup in each run and prevents the resource accumulation that was causing quota issues.