fix: use core.RetryInterval on every function that waits for a resource #4913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
rdb
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
===========================================
- Coverage 75.45% 56.22% -19.24%
===========================================
Files 202 308 +106
Lines 44323 77767 +33444
===========================================
+ Hits 33444 43722 +10278
- Misses 9653 32642 +22989
- Partials 1226 1403 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
remyleone
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, cassettes get replayed in real time (the request's duration is simulated) so we should make sure that
core.RetryIntervalis set in every wait function as retry interval, because its value is set to 0 when replaying cassettes.That should make the commit CI a bit faster.