feat(instance): remove 'public' argument for listing images #5032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mia-Cross
added
bug
instance
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #5032 +/- ##
===========================================
- Coverage 75.45% 56.24% -19.21%
===========================================
Files 202 308 +106
Lines 44323 78053 +33730
===========================================
+ Hits 33444 43903 +10459
- Misses 9653 32743 +23090
- Partials 1226 1407 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mia-Cross
force-pushed
the
instance_image_list_public_images
branch
from
5c11e27 to
8095607
Compare
Mia-Cross
changed the title
remyleone
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of the 'public' argument when listing images is confusing and since public images are barely used, we decided to drop the argument completely and only allow listing private images.
Closes #4951