DOC: fix convergence warning in iterative example #14330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The estimator fails to converge reliably even with 1e4 iterations. We can keep the default max_iter and avoid convergence warnings increasing the tolerance.
|
That seems a bit weird. Do you know which estimator this is for? |
|
This is really strange, the estimator is not converging at all. This looks like a bug to me. I opened #14338 and I think we should investigate the actual issue. |
|
😬 |
|
Is this good to go? Or is the idea that we want to wait for the fixes coming to the IterativeImputer first? |
|
@deniederhut I would argue that it's not good to try and hide the warning and we should fix the underlying bug. |
|
Cool, then let's close this in favor of whatever PR closes #13773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Resolves on check box from #14117
What does this implement/fix? Explain your changes.
The estimator fails to converge reliably even with 1e4
iterations. We can keep the default max_iter and avoid
convergence warnings by increasing the tolerance.
Any other comments?
Before change:
After change: