GRAPHICS: Remove or deprecate RGBA palette functions in ManagedSurface #4541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccawley2011
changed the title
|
This is very good. Thank you for looking into it. |
|
I have no notes and merging this. Great changes, great attention to detail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Palettes with alpha transparency are not used by any engines, and using a different format for palettes compared to the rest of ScummVM prevents blitting code from being reused, in addition to some ambiguity for engines calling
setPaletteorgetPalette.This PR only changes the public interface, adapting
ManagedSurfaceitself to use a standard palette format will be done in a follow-up PR.This is currently a draft until proper testing can be done.