SCUMM: INPUT: Don't substitute Left/Right clicks in HE games. #4664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These (later) games can have scripts that accept Enter and Tab keys.
LittleToonCat
force-pushed
the
fix-he-input
branch
from
0879053 to
1afa7d0
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Games such as the Backyard Sports titles have scripts that allow users to press the Enter key to submit name input, while Moonbase Commander accepts the Tab key as the default binding to enable multiplayer chat. The Enter/Tab keys to Left/Right click substitution breaks that. This PR fixes that so that the substitution will only take place in DOS-era HE games (versions less than 71), not the later ones.