COMMON: Simplify API for getHumanReadableBytes() #4679
Conversation
There was a problem hiding this comment.
I am not sure this PR goes in the right direction.
Instead of migrating from Common::String to char *, I think it should go to Common::U32String to allow for translated units.
Currently in the Weblate, KB is already translated КБ for Russian and Ukrainian languages and I don't really know how it behaves for now.
| return Common::U32String::format(_("Download speed: %s %S"), speed.c_str(), _(speedUnits).c_str()); | ||
| const char *speedUnits; | ||
| Common::String speed = Common::getHumanReadableBytes(CloudMan.getDownloadSpeed(), speedUnits); | ||
| return Common::U32String::format(_("Download speed: %s %S/s"), speed.c_str(), _(speedUnits).c_str()); |
There was a problem hiding this comment.
I don't know why it was like this but %S means wide-char (and is not recommended).
You are passing an 8-bit string.
There was a problem hiding this comment.
_() converts the input to Common::U32String, and Common::U32String::format uses a custom implementation where %S always uses 4-byte chars.
The use of |
|
Oh! OK, I see. Nice! LGTM. |
|
Nice, thank you! |
3 participants
This makes it easier to use in debug commands, avoids unnecessary string conversions and fixes a few cases where the units weren't being translated correctly.