DC: BUILD: Always disable SCUMMv7+ on Dreamcast (Bug#6008) #4693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Trac#6008 for some context.
With the recent v7/v8 changes in the SCUMM engine, trying to run a v7/v8 SCUMM game is not a nice user experience anymore, because the game just won't fit in the limited default memory available on Dreamcast.
This is also a problem for some other engines on this platform, but the SCUMM engine being one of the most popular engines, quite a lot of users end up burning a toast CD-R on their Dreamcast until they figure out that only SCUMMv6 and earlier still work nowadays (with some limitations, too). Disabling v7/v8 from the SCUMM engine plugin should also free up some memory for a better experience with earlier SCUMM titles (from a quick test,
scumm.plggets ~15% smaller).This PR hardcodes this behavior into
configureso that we're sure thatscumm-7-8is never enabled there. I'm doing this there (and not in dockerized-bb) because AFAIK the Dreamcast release builds are not made from the buildbot. A nicer solution (as discussed on Discord) would be to have a way to know about "capabilities" (or something similar) between backends and engines, but this PR is mainly meant as a quick fix for the 2.7.0 release.@zeldin: Do you agree with this approach? SCUMM v7/v8 has been limited on DC for years, and it's been confirmed to be useless recently, and we have no immediate fix for this, so for end-users I think this is fair.
Please DON'T MERGE unless @zeldin is OK with it. Thanks.