AGS: Fix FileStream::EOS when used on a file opened for writing #4700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EOS should always return false in this case.
lephilousophe
force-pushed
the
fix-eos
branch
from
bffaebc to
e216cde
Compare
|
Thank you @lephilousophe. Unfortunately, this doesn't solve the issue, as |
As the cursor is always at the end of the stream, BufferedStream::EOS() always return true. We check for errors when writing so no check is needed here.
|
Now ok on big-endian with the new commit! Thanks |
|
I propose to keep the first commit as it still behaves better than before. |
|
Merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EOS should always return false in this case.
This should fix #13417.
If this works, this needs to be backported to 2.7