The purpose of Common::remove_const (and std::remove_const outside of ScummVM` is not to remove the const specifier from a variable, but to remove it from a type and define a non-const type in the process. It is typically use in template code, such as this example given by @lephilousophe on Discord (thanks, that saved me the trouble of creating one myself 😄 ):

template<typename T>
class Test {
  Common::remove_const<T> mutable_item;
  T *array;
}

The previous commit to fix the warning thus did not fix anything as the code was still doing a C cast from a const type to a non-const one to remove the const specifier from the byte array. The proper way to fix that warning is to use a const_cast, as done in this pull request.

The main reason I am not committing this directly and opening a pull request is to give it more visibility, as I am sure more developers might be confused by the purpose of Common::remove_const and use it incorrectly .