KEMBAR78
DEVTOOLS: Add create_nancy project by fracturehill · Pull Request #4734 · scummvm/scummvm · GitHub
Skip to content

Conversation

@fracturehill
Copy link
Contributor

This PR adds a create_nancy project to /devtools/, which in turn
generates a nancy.dat datafile. The file contains a variety of
Nancy Drew engine-specific data, including dialogue strings,
debug strings, and game logic.

This PR compiles the data from the first two games, The Vampire
Diaries and Nancy Drew: Secrets Can Kill. The resulting nancy.dat
file is about 40k, but that's bound to grow as more games are added.

I'm posting this as a PR mostly because I'm not sure if I've done
something egregiously wrong when adding the project to /devtools/,
but all comments are appreciated :)

Add initial version of create_nancy, which generates a datafile(nancy.dat) containing various data for games using the Nancy Drew engine.
Added an initial version of nancy.dat to dists/game-data
Changed a couple of type definition to (hopefully) fix the buildbot
compiler errors
Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code, and there are no notes from me.

Yes, it is the correct place and approach for creating the data file.

The only missing part is adding nancy.dat to different deployment lists, including the buildbot. I will do it right after the merge.

@sev- sev- merged commit 8e0d4df into scummvm:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants