GLK:SCOTT: Fix assert failed after calling Scott::fatal() #4745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this makes ScummVM exit cleanly instead of crashing with an assert when trying to run an unsupported game. |
sev-
reviewed
Mar 1, 2023
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised by 14257, Scott engine gives error of
scummvm: ./common/array.h:234: T& Common::Array<T>::operator[](Common::Array<T>::size_type) [with T = Glk::Scott::Item; Common::Array<T>::size_type = unsigned int]: Assertion idx < _size' failed.It happens because the shouldQuit() function
scummvm/engines/glk/scott/scott.cpp
Line 145 in c7c2141
Fixed it by checking if there is quit event when calling saveCurrentState()!