ANDROID: Add ability to delete files #4749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use our brand new remove feature in filesystem
antoniou79
reviewed
Feb 28, 2023
antoniou79
reviewed
Feb 28, 2023
antoniou79
reviewed
Feb 28, 2023
| env->DeleteGlobalRef(_safNode); | ||
| _safNode = nullptr; | ||
|
|
||
| // Create the parent node to fetch informations needed to make us a non-existent node |
There was a problem hiding this comment.
I am unsure I completely understand what we're doing starting from here. The comment helps a bit, but still maybe a bit more clarification needed?
antoniou79
reviewed
Feb 28, 2023
There was a problem hiding this comment.
I've added my review.
In general it looks good to me.
I am not sure how useful it would be to work on folder deletion (I read the comment that we're not dealing with this yet, and I agree).
I have not tested to build and test on my devices yet. But I'm ok to merge and test after. It's simplest too
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And create a specific save manager which uses this new ability to delete saves.
This makes deleting saves on SAF possible.