SAGA2: Fix Wrong spellID crash when using spells from inventory! #4751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function skillProtoFromID, magic.cpp the logic to get skill is simple, If the id given is greater than maximum spells then it simply returns game object from address, whereas if not then it will return spell from the spell book! This is based upon the assumption that Spell objects will have IDs > the number of spells, however, it sometimes happens that spell object get Id between this safe range, thus the error of Wrong spellID.
The patch fixes this by fetching the game object from the address and checking if it is a spell, If it is, then it simply returns the address, else checks for range.