ANDROID: Rewrite cache to make it more efficient #4762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lephilousophe
force-pushed
the
android-better-cache
branch
2 times, most recently
from
7ddb4b9 to
04eb5d5
Compare
Instead of caching path string, cache nodes and their children. This allows a better tracking of what is in cache and what is not. Use SoftReference to allow for simple cleanup and ensure we have unique SAFFSNode instances.
lephilousophe
force-pushed
the
android-better-cache
branch
from
04eb5d5 to
f05677e
Compare
|
Merging as discussed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of caching path string, cache nodes and their children. This allows a better tracking of what is in cache and what is not.
Use SoftReference to allow for simple cleanup and ensure we have unique SAFFSNode instances.
This PR is an alternative to #4761