KEMBAR78
[RFC] SCUMM: COMI: Add option to enable "A Pirate I Was Meant To Be" for non-ENG versions by AndywinXp · Pull Request #4772 · scummvm/scummvm · GitHub
Skip to content

Conversation

@AndywinXp
Copy link
Contributor

As asked by @lotharsm about 7 years ago (#7887), here's this little nice addition. 😄

The check does not appear in the options if the user is using the ENG version of the game, of course.

@BLooperZ
Copy link
Contributor

BLooperZ commented Mar 5, 2023

Awesome, thank you :)
cc @orgads

@dwatteau
Copy link
Contributor

dwatteau commented Mar 5, 2023

Playing with boot param 465 on the French version, this appears to work, although the end result is quite bad since it's just an early, incomplete and not really well done work in progress in that language.

But since it's an opt-in, I think it's still a welcome change there. Thanks!

Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is awesome!

@lotharsm
Copy link
Member

lotharsm commented Mar 6, 2023

Thank you, it works like a charm on the German version. Even some of the subtitles are translated there :-D

@AndywinXp
Copy link
Contributor Author

Thanks everyone! Merging 😄

@AndywinXp AndywinXp merged commit d3bd4f6 into scummvm:master Mar 6, 2023
@AndywinXp AndywinXp deleted the pirateSongOption branch January 31, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants