BUILD: Disable -Wshadow and -Wmissing-field-initializers before GCC 5 #4779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They just gave many false positives creating a lot of noise in build logs for ports using an older GCC.
|
This looks like a pretty reasonable change. I admit the inverted Wno-* bit threw me for a second, but as far as I can see this should be fine. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-Wshadowand-Wmissing-field-initializersGCC flags gave many false positives before GCC 5, and this creates a lot of irrelevant noise in the build logs. See the Ubuntu 20.04 g++ 4.8 CI for an example, or the Dreamcast or RISC OS buildbots. Even Linus complained about the old-Wshadowat the time.The flags are now only enabled on Clang builds and GCC >= 5 builds.