KEMBAR78
GLK: ADRIFT: Add detection for new games (#-A) by MarcoBorrini99 · Pull Request #4781 · scummvm/scummvm · GitHub
Skip to content

GLK: ADRIFT: Add detection for new games (#-A) #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 7, 2023
Merged

GLK: ADRIFT: Add detection for new games (#-A) #4781

merged 5 commits into from
Mar 7, 2023

Conversation

@MarcoBorrini99
Copy link
Contributor

ADRIFT: [#-A] Title Mass Update

This commit add/fixes entries from the following sources:

tag2015
tag2015 reviewed Mar 6, 2023
View reviewed changes
engines/glk/adrift/detection_tables.h Outdated
DT_ENTRY0("mysteryhouse", "9c7f8577c506737cc07d026d8318598e", 4916),
DT_ENTRY0("neighboursfromhell", "686d8c0995aa085fb056c6a5bd402911", 13520),
DT_ENTRY0("oct31", "7ca7980f7adf3da370464610b702e94b", 356192),
DT_ENTRY1("oct31", "Danish", "7f0637944bc69e2bff843e76689b645b", 194758), // TODO: How can I enter Danish language?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this:
DT_ENTRYL0("oct31", Common::DA_DNK, "7f0637944bc69e2bff843e76689b645b", 194758),

Copy link
Contributor Author

@MarcoBorrini99 MarcoBorrini99 Mar 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed wrong entry for Danish title

@tag2015
Copy link
Contributor

tag2015 commented Mar 7, 2023

Great work, thanks! A few tips for future PRs:

  1. The commit message should always begin with GLK: ADRIFT:
    Also it should be a bit clearer such as
    GLK: ADRIFT: Add detection for new games (#-A)

  2. You should update your fork using git pull --rebase (or set the config option pull.rebase=true) to get rid of the "merge" commits

@MarcoBorrini99 MarcoBorrini99 changed the title ADRIFT: [#-A] Mass Update GLK: ADRIFT: Add detection for new games (#-A) Mar 7, 2023
@MarcoBorrini99
Copy link
Contributor Author

@tag2015 Just learned NOT to put # and a number in local commit comment, anyway this PR is now complete, do I need to do something particular?

@tag2015
Copy link
Contributor

tag2015 commented Mar 7, 2023

@tag2015 Just learned NOT to put # and a number in local commit comment, anyway this PR is now complete, do I need to do something particular?

Everything OK, I'll squash to a single commit and merge.
Thanks!

@tag2015 tag2015 merged commit ce6b38c into scummvm:master Mar 7, 2023
@cedricl31
Copy link

Hello,
I've searched everywhere and no trace of the following game :
DT_ENTRY0("stardust", "caa5cdc48e4f23bad3a6893b5fd2b2a4", 35343),

The offical S Tar Dus T game available at Adrift.co has the following signature
{"2_s_tar_dus_t.taf", 0, "0d0a2aa60004be9b02b1a212b3cd582e", 42463},

Do you have a source for your S tar Dus T edition ?

@MarcoBorrini99
Copy link
Contributor Author

S Tar Dus T (English).zip

@cedricl31
Copy link

Thanks a lot Marco !
And thank you for your huge update on Adrift Games detection. Very appreciated !
Cédric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tag2015 tag2015 tag2015 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcoBorrini99 @tag2015 @cedricl31