-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
MOHAWK: RIVEN: Fix autosave on exit during cutscene #4820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reposition autosave call to precede any changes to game state that follow the exit call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I didn't test it.
|
If I understand correctly:
After PR:
Is this a correct summary? Would it be possible to save just before the cutscene plays (when autosave is enabled) so the user loses minimal progress? |
Yes. And just to clarify, currently exiting a cutscene containing an interactive component produces an autosave which displays a misleading thumbnail image of the exact scene at the time of the exit call. However, when launched, the saved game always begins after the entire cutscene is skipped, the same as a normal cutscene.
The million dollar question! It's something I've often thought about, and would be a great improvement, but I simply don't know. And since the departure of bgK from the project, I'm not aware of any other devs with enough knowledge of the engine to reliably answer that question. Nevertheless, it's not all gloom and doom. The user always has the option to manage the situation by selecting the minimum autosave interval, and accessing the main menu indicates that saving is disabled, so the user can opt to delay the exit at their discretion. |
|
As is, and since it is the intended behavior, the PR looks good to me too. |
|
Thanks! |
An issue exists where an autosave is performed when exiting the game during a cutscene, even though normal saving is disabled at this time.
When exiting the game during a cutscene, the game skips ahead to the first interactive frame outside the cutscene, then completes the exit.
Currently, the autosave is called after this change to the game state, creating the opportunity to complete an unexpected save that skips the unseen portion of the cutscene.
Fixed by repositioning the saveAutosaveIfEnabled() call to a position before the game state is changed, ensuring the autosave is always attempted based on the game state, and save condition, existing at the time the exit call is initiated.
In this example, the autosave fails to complete, as expected.
Fixes bug 11440.