I18N: Add script to automatically generate scummvm.appdata.xml from .po files #4826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
requested changes
Mar 20, 2023
devtools/generate-appdata.py
Outdated
| description_elem.appendChild(p_elem) | ||
|
|
||
| # paragraph 3 | ||
| p_elem = doc.createElement("p") |
There was a problem hiding this comment.
Please, turn it into a simpler template. Working with current soup of in-code tags is not practical
There was a problem hiding this comment.
Fixed and changed the code to have an in-source copy of the template and added code to substitute specific keywords with relevant translations.
dists/scummvm.appdata.xml
Outdated
| <project_license>GPL-3.0-or-later</project_license> | ||
| <name>ScummVM</name> | ||
| <summary>Interpreter for numerous adventure games and role-playing games</summary> | ||
| <summary xml:lang="ru">Интерпретатор множества приключенческих и ролевых игр</summary> |
There was a problem hiding this comment.
These, and other language tags should be sorted alphabetically, so their sequence stays consistent
…ags alphabetically
ankushdutt
changed the title
ankushdutt
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to support multilanguage in scummvm.appdata.xml. The multilanguage data is extracted from po/*.po files.
Related Discord discussion: https://discord.com/channels/581224060529148060/1086942326489895033/1086976457311531058