NUVIE: Fix Ultima 6 projectile collision #4838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the line drawing algorithm used in projectile collision detection operate in screen space to match the original game. Before this change the calculation was done in tile space, which caused incorrect results.
|
Found a regression: The castle drawbridge crank can no longer be used when standing on the tile to the NE of it. Converting to draft for now. |
Fix regressions by only scaling coordinates when handling projectiles.
|
Changed to affect projectiles only. Thanks for the quick merges btw (I see you are quite busy with MM1 already). |
|
No problem. I've been delighted that someone's had the interest to take on giving the Nuvie code some TLC, just like Ultima 8 has had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the line drawing algorithm used in projectile collision detection operate in screen space to match the original game.
Before this change the calculation was done in tile space, which caused incorrect results.
Note that the modified method Map::lineTest() is also used in other parts of the code unrelated to projectiles. Regressions are possible. If it breaks anything projectiles might need to be handled separately.
To reproduce the incorrect behavior :
In the original game the pillar will block the shots.