DIRECTOR: Add support for "set picture of cast" and "get picture of cast" #4843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somaen
force-pushed
the
director_picture
branch
2 times, most recently
from
2784e17 to
aa55db0
Compare
sev-
approved these changes
Mar 25, 2023
…oder This is in preparation for allowing for Lingo to get/set the picture of BitmapCastMember. In particular, storing a Picture lets us easily replace the existing image (instead of having to rely on ImageDecoder as source). Also, having Picture instances that are easy to copy will make lifetime management easier if pictures are copied into longer-living things such as globals.
somaen
force-pushed
the
director_picture
branch
from
6ecf6a9 to
97a1327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a refactor of how BitmapCastMember deals with it's picture, so that we can get/set the picture. In particular we now pass around copies, so that we can ensure that if we set a global to the picture of some cast member, the picture survives the cast member from which it came.