GUI: Dump .png files of the launcher to check UI for various translations #4844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoenixFlame101
force-pushed
the
dump-dialogs
branch
2 times, most recently
from
4503d43 to
207b389
Compare
PhoenixFlame101
changed the title
sev-
requested changes
Mar 29, 2023
gui/dump_all_dialogs.h
Outdated
| * | ||
| */ | ||
|
|
||
| #ifndef DUMPDIALOGS_H |
There was a problem hiding this comment.
This must be GUI_DUMP_ALL_DIALOGS_H
| GUI::LauncherChooser chooser; | ||
| chooser.selectLauncher(); | ||
| chooser.runModal(); | ||
| g_system->grabOverlay(surf); |
There was a problem hiding this comment.
Starting from here, please put it into a separate method something like saveGUISnapshot().
| Graphics::Surface surf; | ||
| surf.create(g_system->getOverlayWidth(), g_system->getOverlayHeight(), g_system->getOverlayFormat()); | ||
|
|
||
| GUI::LauncherChooser chooser; |
There was a problem hiding this comment.
Please, add at least one more dialog to dumping.
gui/dump_all_dialogs.cpp
Outdated
|
|
||
| namespace GUI { | ||
|
|
||
| void GUI::dumpDialog(const Common::String &dialogName, int res, const Common::String &lang) { |
There was a problem hiding this comment.
please rename this to dumpDIalogs(), so we add more than one dialog here for dumping.
- Each resolution needs to be cycled manually in the code, default is
800x640.
- Dumps .png files in a snapshots folder for all languages at a given
resolution.
TODO:
- Cycle resolutions automatically through code.
- Add more dialogs to the dumper.
- Add arguement message with default arguement "test" - Create separate .png files for all dialogs
PhoenixFlame101
force-pushed
the
dump-dialogs
branch
from
207b389 to
c38148f
Compare
|
Merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: