KEMBAR78
DREAMWEB: specify CLUT8 format for titles modes by spleen1981 · Pull Request #4848 · scummvm/scummvm · GitHub
Skip to content

DREAMWEB: specify CLUT8 format for titles modes #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2023
Merged

DREAMWEB: specify CLUT8 format for titles modes #4848

merged 1 commit into from
Apr 4, 2023

Conversation

@spleen1981
Copy link
Contributor

If not specified, format selection may fall back to g_system->getSupportedFormats().front(), which may provide a not appropriate format (e.g. RGBA8888@4 will not display titles correcty).

@spleen1981 spleen1981 mentioned this pull request Mar 28, 2023
Closed
@spleen1981 spleen1981 requested a review from phcoder March 28, 2023 14:03
@criezy
Copy link
Member

criezy commented Apr 4, 2023

Good catch!

This is indeed a regression from 13eb6f3.
In that commit the code was switched from using Engine::initGraphics() to using Engine::initGraphicsAny(). However it does not specify a pixel formats and the behaviour of those two functions differ in that case. The former uses CLUT8, while the latter, as you indicated, uses g_system->getSupportedFormats().front(). Fortunately the change was recent and is not included in the 2.7.0 release 😌

Thank you.

@criezy criezy merged commit 4cd4af4 into scummvm:master Apr 4, 2023
@spleen1981 spleen1981 deleted the dreamweb_fix_title_initsize branch April 11, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phcoder phcoder Awaiting requested review from phcoder

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spleen1981 @criezy