DIRECTOR: Update MCI parser #4850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the old MCI parser to work based on the specification described in https://patentimages.storage.googleapis.com/ad/06/7a/48766ca9df6fbc/US6397263.pdf - Replaced the old code to showcase how each MCI command can now be handled through the parsed_cmd object. Microsoft MCI documentation: https://learn.microsoft.com/en-us/windows/win32/multimedia/mci Parser code used as reference: https://github.com/wine-mirror/wine/blob/master/dlls/winmm/mci.c
If the the 'to' parameter is absent from an MCI_PLAY command, the device now plays unitl the end.
- Make some small formatting changes. - Removed int cast from uint when indexing
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DIRECTOR: Update MCI parser
on the official MCI standard.
engines/director/lingo/lingo-mci.cpp