KEMBAR78
DIRECTOR: Set 'the result' for calls, Normalise xlib calls for mac delimiters (:, @:), Working Saves for TD! by hari01584 · Pull Request #4851 · scummvm/scummvm · GitHub
Skip to content

DIRECTOR: Set 'the result' for calls, Normalise xlib calls for mac delimiters (:, @:), Working Saves for TD! #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2023
Merged

DIRECTOR: Set 'the result' for calls, Normalise xlib calls for mac delimiters (:, @:), Working Saves for TD! #4851

merged 4 commits into from
Mar 29, 2023

Conversation

@hari01584
Copy link
Contributor

Pull request is fragmented into three atomic commits for each of these, please review!

  1. Set 'the result' for calls - Before this, the value of the result was not being set in XObject/Factory calls, this patch fixes it and thus the result will now be set after each caller! (eg. used for FileIO, for verifying status of operation after executing handler)
  2. Normalise xlib calls for mac delimiters - Before patch, delimiters such as : and @: were not removed from openXLib calls, this patch fixes it and removes them.
  3. Fully working Saves for total distortion! - Load/Save games are fully working, also the same goes for loading/saving video files under total distortion!

@hari01584
DIRECTOR: Set value of 'the result' from call returns
0d004bb 
Used when determining save/load success in the totaldistortion-win
@hari01584
DIRECTOR: Normalize xlibname to remove mac path delimiters :, @:
6b44fa0 
totaldistortion-win calls many libraries with @:xlibName format
@hari01584
DIRECTOR: Fix directory seperator while splitting path into dir, file…
321b752 
…name

Used in formatting paths(C:\totaldistortion-win-savename.TDG) while loading/saving in totaldistortion-win
@sev-
Copy link
Member

sev- commented Mar 29, 2023

Thank you!

@sev- sev- merged commit 9cb6a98 into scummvm:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hari01584 @sev-