NOTE: please test on big endian machines

It might take me some days to do this, maybe @raziel- could help? Otherwise, I'm not sure I'm going to have time to test this before next week, FWIW.

Thanks

I've seen this and have it on my todo list.
Unfortunately I'm also not able to test before april

It would be simpler to call glReadPixels with GL_RGB instead of doing the conversion afterwards.

It would be simpler to call glReadPixels with GL_RGB instead of doing the conversion afterwards.

You mean just changing line 1747 to
GL_CALL(glReadPixels(0, 0, width, height, GL_RGB, GL_UNSIGNED_BYTE, &pixels.front()));
and initialize the data Surface using the RGB888 pixelformat?
That doesn't work, at least on my Win10. The resulting image is always corrupted

Indeed I missed the GL_PACK_ALIGNMENT which is set up to 4.
I have something working on Linux here: lephilousophe@40112c5

Indeed I missed the GL_PACK_ALIGNMENT which is set up to 4. I have something working on Linux here: lephilousophe@40112c5

Thanks! I can confirm that your version works with Windows as well.

I updated this PR with my changes but I rebased without building.
So I wait for the CI to finish and merge this.