NUVIE: Fix Ultima 6 spawn probability #4857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mark spawn eggs as unstackable. - Normalize the random number used to be in the range 1 to 100 inclusive to match original behavior. Stackable objects store "quality" in the high octet of uint16 "qty". Since "qty" is used as the probability of an egg activating, spawns would always trigger unless "quality" was 0.
Match original behavior when randomizing the number of entities spawned by eggs.
|
Looks good to me. I'm impressed that you were able to notice it. |
|
@PushmePullyu By that way. I've been very impressed with your work so far, and was wondering if you'd be interested in becoming an official team member and working on improving Nuvie directly. If so, at your convenience if you could join the #scummvm Discord channel and drop sev a line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change NPC and object spawn probability and count to match original behavior.