COMMON: Upgrade InstallShield archive code #4868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for files split across volumes, and for multi-volume v5 archives to the InstallShield cabfile code.
Fixed the InstallShield archive code to correctly load the file list in multi-cabinet v5 archives.
|
SCI has one game where we use InstallShield, the Polish version of Leisure Suit Larry 7. With this change, it now errors and isn't able to read the file I confirmed that |
Files marked as invalid are now ignored in all IS versions. Trying to extract an obfuscated file now results in a warning instead of just failing.
|
@sluicebox Fixed the issue, can confirm the game boots correctly now. Thanks for testing :) |
|
Re-tested and it works now, thanks! |
|
Thank you, good stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for InstallShield cabinets with files split across
volumes. It should, in theory, also add support for format v5
cabinets with multiple volumes, but I don't have any on hand
to test with.
Code is based on unshield.