KEMBAR78
SLUDGE: Add detection for v 1.0 outoforder by pressspacetojump · Pull Request #4883 · scummvm/scummvm · GitHub
Skip to content

SLUDGE: Add detection for v 1.0 outoforder #4883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2023
Merged

SLUDGE: Add detection for v 1.0 outoforder #4883

merged 2 commits into from
May 14, 2023

Conversation

@pressspacetojump
Copy link
Contributor

@pressspacetojump pressspacetojump commented Apr 5, 2023 •
edited
Loading

I've double checked the version, and did not found v0.1

sev-
sev- requested changes Apr 9, 2023
View reviewed changes
Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix two little thing and change the commit log message to be specific, which game you added, like: "SLUDGE: Added detection for v 0.1 of outoforder"

By changing the commit, DO NOT CLOSE this PR. Rather just force-push and GitHub will pick it up.

@pressspacetojump pressspacetojump changed the title SLUDGE: Add game to detection table. SLUDGE: Add detection for v 1.0 outoforder Apr 9, 2023
pressspacetojump
pressspacetojump commented Apr 9, 2023
View reviewed changes
Copy link
Contributor Author

@pressspacetojump pressspacetojump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. added version for the pervious entry as well

@pressspacetojump pressspacetojump requested a review from sev- April 14, 2023 21:47
@sev-
Copy link
Member

sev- commented May 14, 2023

Thanks!

@sev- sev- merged commit 195e54f into scummvm:master May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sev- sev- Awaiting requested review from sev-

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pressspacetojump @sev-