GOB: remove game type AJWorld, duplicated with Adibou1 #4884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A.J.'s World of Discovery is the name of the US localization of Adibou 1.
The only file listed in SaveLoad_AJWorld ("menu.inf") has been moved to SaveLoad_Adibou1.
|
Actually, you could use functionality for autoupgrading targets. see "engines/obsolete.h", and how it is used in AGOS engine. It is just a matter of defining a table. |
|
@sev- Nice, I didn't know we had this feature. Added. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the game type kGameTypeAJWorld, which refers to the same game as kGameTypeAdibou1 ("A.J.'s World of Discovery" being the name of the Adibou 1 US localization).
This would force users to re-add the game, but it should be acceptable as it is not officially supported yet and marked as unstable. There were no persistent save games already implemented for kGameTypeAJWorld.
The same duplication exists in the "game" tab of the ScummVM data Google sheet ; would there be other places to check ?