GRAPHICS: Fix incorrect Win cursor mask behavior when a non-white color is masked #4885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasota
force-pushed
the
fix-riven-cursors
branch
4 times, most recently
from
5057263 to
27ff350
Compare
…e and treat any other color with AND mask value 1 as transparent. Fixes incorrect cursor transparency in Riven.
elasota
force-pushed
the
fix-riven-cursors
branch
from
27ff350 to
e59bbf1
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cursor loader flags pixels as inverted if the pixel's color index is non-zero.
Per the WDDM spec, a pixel with 1 in the AND field is inverted if the color is white. No behavior is defined for pixels with non-white color, but in practice, the behavior Windows uses is that any other color becomes transparent.
This fixes the cursor loader to reflect that behavior.
Fixes https://bugs.scummvm.org/ticket/14386