SCUMM HE: Add "Create session" dialog for Football 2002. #4886
Conversation
| res = 1; | ||
| break; | ||
|
|
||
| case 1030: |
There was a problem hiding this comment.
Eventually, we need to derive these enums from the original
| // If there's a custom game name, use that instead. | ||
| if (ConfMan.hasKey("game_session_name")) { | ||
| Common::String gameSessionName = ConfMan.get("game_session_name"); | ||
| return _vm->_net->hostGame(const_cast<char *>(gameSessionName.c_str()), userName); |
There was a problem hiding this comment.
c_str() is already char *. Is this cast really needed?
There was a problem hiding this comment.
c_str() actually returns an const char*, which will result in an invalid conversion error. So this cast is indeed needed.
| if (runDialog(createDialog)) { | ||
| return -1; | ||
| } else { | ||
| return -2; |
There was a problem hiding this comment.
As I understand, these magic numbers are processed by the SCUMM scripts. Still, of possible, I'd prefer turning them into enums.
gui/themes/common/highres_layout.stx
Outdated
| width = '480' | ||
| height = '250' | ||
| /> | ||
| <layout type = 'horizontal' padding = '-80, 8, 8, 8'> |
There was a problem hiding this comment.
That's unusually high negative padding. How does it look like?
There was a problem hiding this comment.
This was done so that the label and edit boxes would properly appear to the left of the dialog instead of the center. And for comparision, here's with the default 8 padding:
Actually, now that I think about it, it doesn't make too much of a difference, I'll revert the padding back to 8.
There was a problem hiding this comment.
Edited and force pushed the themes commit with padding now set to 8.
gui/themes/common/lowres_layout.stx
Outdated
| width = '480' | ||
| height = '250' | ||
| /> | ||
| <layout type = 'horizontal' padding = '-80, 8, 8, 8'> |
There was a problem hiding this comment.
-80 is like 1/4 of a 320 pixels wide screen. Doesn't feel right. Could you please post a screenshot?
LittleToonCat
force-pushed
the
create-session-dialog
branch
from
d20273a to
93c5d4e
Compare
|
Thanks! |
2 participants
This adds a new dialog box allowing the user to name for their network game session in Backyard Football 2002. This also adds the ability to set their own name in both the Host and Join session dialogs.