KEMBAR78
SCI32: Mark PQ:SWAT demo as unsupported by dwatteau · Pull Request #4892 · scummvm/scummvm · GitHub
Skip to content

Conversation

@dwatteau
Copy link
Contributor

@dwatteau dwatteau commented Apr 8, 2023

See bug #14388 for details: the PQ:SWAT demo (pqswat-win-demo-en.zip) requires version 4 robot decoding, which is not implemented yet.

Submitting this as a PR just in case, since I'm not really familiar with the way this engine is maintained :)

@sluicebox
Copy link
Member

I've demoted other SCI game versions to unsupported once we've discovered that they in fact weren't done, so yes this appropriate.

Let's keep the "Demo" string and just add a comment to the detection entry that it uses Version 4 of Robot videos, which we just haven't implemented yet in RobotDecoder. The "Missing game code" is for the severe case of Shivers2 where the entire game is implemented in c++ instead of scripts. This isn't that kind of fatal situation, someone just needs to care about pqswat and they can knock this out in an afternoon. (One Two Three, Not It!)

See bug #14388: this demo requires version 4 robot decoding, which is not
implemented yet.
@dwatteau dwatteau force-pushed the fix/sci-pq-swat-demo-mark-as-unsupported branch from 6edb88f to b0276f6 Compare April 9, 2023 08:31
@dwatteau
Copy link
Contributor Author

dwatteau commented Apr 9, 2023

@sluicebox OK, thank you. As for keeping the "Demo" string, the problem is that, AFAICS, AdvancedMetaEngineDetection has that design limitation where you need to replace the extra flag with an explanation about why the game is unsupported; otherwise, if a user tries starting the game, the explanation printed by the UI will just be "Demo".

So I've tried to find a compromise, but maybe something more elegant can be done around AdvancedMetaEngineDetection, I don't know.

@ccawley2011
Copy link
Member

Is there any existing code or documentation that can be referred to regarding Robot v4?

@sluicebox
Copy link
Member

@ccawley2011 We have resources. This is just a TODO that didn't happen before the previous developer left. Anyone who wants to implement this, ping me on discord. =)

@dwatteau Thanks for the explanation; I wouldn't have guessed the GUI did that. Good compromise!

@sluicebox sluicebox merged commit e00d8af into scummvm:master Apr 10, 2023
@dwatteau dwatteau deleted the fix/sci-pq-swat-demo-mark-as-unsupported branch April 10, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants