VIDEO: Fix signed/unsigned mismatch potentially breaking DXA seek. #4897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks OK, but I'd also recommend changing the skip function to use a 64-bit parameter, as it looks like something that was missed when 64-bit file I/O was first added. That can be done later in a separate PR, though. |
ccawley2011
approved these changes
Apr 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes VS warning that can potentially cause wrong behavior in DXA decoder:
dxa_decoder.cpp(72,18): warning C4245: 'argument': conversion from 'int' to 'uint32', signed/unsigned mismatchskipaccepts a uint32 parameter and then passes it toseekwhich accepts an int64. This is problematic because converting -4 to a uint32 may cause it to become 4294967292, causing the seek to fail if the underlying stream doesn't demote it back to 32-bit.