GRAPHICS: Fix cursor surface when bytes per pixel greater than one #4898
Conversation
| _size = surf.w * surf.h * surf.format.bytesPerPixel; | ||
|
|
||
| // make sure that the width == pitch | ||
| _surf.init(surf.w, surf.h, surf.w, new byte[_size], surf.format); |
There was a problem hiding this comment.
All of this looks like Surface::copyFrom.
In this case, a _surf.free() must be called inside the destructor.
There was a problem hiding this comment.
As this init sets the pixels with new[], the destructor currently uses delete[] (byte *)_surf.getPixels()
There was a problem hiding this comment.
Indeed. The new[] statement is crucial. Had we used create, linearity of the buffer wouldn't be guaranteed. So we must to delete[] it and not free it.
There was a problem hiding this comment.
Indeed. The
new[]statement is crucial. Had we usedcreate, linearity of the buffer wouldn't be guaranteed.
I don't understand what you mean by this.
What new[] brings over malloc used in create which prevents us to use create instead of these lines?
There was a problem hiding this comment.
We can't make assumptions of what create does. I just happen to know because I was to one who changed its (malloc) behaviour for my platform: https://github.com/scummvm/scummvm/blob/master/graphics/blit-atari.cpp#L101
|
Good catch. I did test it with |
|
Thanks! |
4 participants
No description provided.