KEMBAR78
GUI: Fix hard shadow under HiDPI rendering by su-xingyu · Pull Request #4908 · scummvm/scummvm · GitHub
Skip to content

Conversation

@su-xingyu
Copy link
Contributor

Decrease the number of rendered shadow rectangles under HiDPI

  • Introduce shadowIntensity (encoded using 16 bits mantissa) which indicates the interval for drawing shadow rectangles

Decrease the number of rendered shadow rectangles under HiDPI
Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple minor comments

- Change initialization value to avoid possible infinite loop

- Add warning message when zero shadow intensity is encountered
@su-xingyu su-xingyu requested a review from sev- April 14, 2023 18:48
@sev-
Copy link
Member

sev- commented Apr 15, 2023

Thanks!

@sev- sev- merged commit c577b1d into scummvm:master Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants