Change orientation detection mechanism on iOS #4918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsamannen
reviewed
Apr 20, 2023
|
Thank you for your review. I think all the issues you reported should be fixed. |
larsamannen
reviewed
Apr 23, 2023
The main change in to use the interface orientation and not the device orientation. This may be different for example when locking the orientation. This also changes the way orientation changes are detected using the documented method. However this means dropping support for iOS 7 as this method is only available since iOS 8, and alternative methods available in iOS 7 have been deprecated in iOS 13. Another change is to properly detect the interface orientation instead of infering it from the view bounds, which was incorrect on some devices.
This was used in the past to make sure the code can be compiled with old compilers that do not support using @available. But we already dropped support for those old compilers, and in many places already used @available without checking first that it can be used.
|
I have rebased on current master and made the necessary modifications to fix the compilation when targeting TvOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix incorrect orientation being detected on some devices, which caused the virtual keyboard to appear in landscape mode instead of portrait mode.
This includes three main changes that are tied to each others: