-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
DIRECTOR: Fixes for D5 support #4923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3eb789 to
1d56c26
Compare
Fixes starting a new game in Operation: Eco-Nightmare
Jamming an absolute Windows path into a filename is allowed on Linux, however Windows isn't as forgiving. It would be nice to preserve the full path of the saved file; unfortunately the SaveFileManager API doesn't support subdirectories. For now just keep the old pattern of [gameid]-[filename].txt. Fixes save games in Operation: Eco-Nightmare
It's possible for games to request files that don't exist in the game path, e.g. C:\WINDOWS\TX2SAVES. As such, the method needs to always include the quirk files, regardless of whether the path exists. Fixes loading save games in Operation: Eco-Nightmare
This is a holdover from the original code, where the cast members were loaded as part of the Score. Cast is now per-movie, so all the resources should be in the one place.
Required for e.g. Inscape games, where movie files contain more data than could (at the time) fit into RAM. Removes a noticable wait when switching movie files.
6fb82a2 to
586d769
Compare
Fixes the loader in Star Trek TNG Episode Guide
sev-
approved these changes
Apr 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
| delete r; | ||
| } | ||
|
|
||
| // Cast library mapping, used in V5 and up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We commonly write "in D5+" in such cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.