KEMBAR78
DIRECTOR: Fixes for D5 support by moralrecordings · Pull Request #4923 · scummvm/scummvm · GitHub
Skip to content

Conversation

@moralrecordings
Copy link
Contributor

No description provided.

@moralrecordings moralrecordings changed the title DIRECTOR: Fixes for V5 support DIRECTOR: Fixes for D5 support Apr 19, 2023
@moralrecordings moralrecordings force-pushed the director_v5 branch 2 times, most recently from d3eb789 to 1d56c26 Compare April 21, 2023 17:12
Fixes starting a new game in Operation: Eco-Nightmare
Jamming an absolute Windows path into a filename is allowed on Linux,
however Windows isn't as forgiving.

It would be nice to preserve the full path of the saved file;
unfortunately the SaveFileManager API doesn't support subdirectories.
For now just keep the old pattern of [gameid]-[filename].txt.

Fixes save games in Operation: Eco-Nightmare
It's possible for games to request files that don't exist in the game
path, e.g. C:\WINDOWS\TX2SAVES. As such, the method needs to always
include the quirk files, regardless of whether the path exists.

Fixes loading save games in Operation: Eco-Nightmare
This is a holdover from the original code, where the cast members
were loaded as part of the Score. Cast is now per-movie, so all the
resources should be in the one place.
Required for e.g. Inscape games, where movie files contain more data
than could (at the time) fit into RAM. Removes a noticable wait when
switching movie files.
Copy link
Member

@sev- sev- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

delete r;
}

// Cast library mapping, used in V5 and up
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We commonly write "in D5+" in such cases

@sev- sev- merged commit 8cb29bd into scummvm:master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants