KEMBAR78
GLK/GLULX: Add multiple entries to detection table from ifdb.org by MarcoBorrini99 · Pull Request #4925 · scummvm/scummvm · GitHub
Skip to content

Conversation

@MarcoBorrini99
Copy link
Contributor

GLK/GLULX: Add multiple entries to detection table from ifdb.org

This PR add all the missing entries from ifdb.org for GLK/GLULX subengine; scummvm compiles so it should be merged.

@tag2015
Copy link
Contributor

tag2015 commented Apr 21, 2023

Could you please fix the "alabaster" duplicate? The rest is fine!

@MarcoBorrini99
Copy link
Contributor Author

Could you please fix the "alabaster" duplicate? The rest is fine!

Fixed!

@tag2015
Copy link
Contributor

tag2015 commented Apr 21, 2023

Thanks!

@tag2015 tag2015 merged commit cd09fd1 into scummvm:master Apr 21, 2023
@MarcoBorrini99 MarcoBorrini99 deleted the glk_glulx-DetectionTables branch April 21, 2023 14:30
@cedricl31
Copy link

Hello Marco,
Very happy to see that you continue to update other engines detection after Adrift !
I think there is a confusion between two games in your Glulx update :

The following entry seems to be linked to the R1 version of "Ein später Besuch" and not to "Der onirische Garten" :
DT_ENTRYL1("deronirischegarten", Common::DE_DEU, "r1/190626", "b201ade8eb29a64892cf1370de3c9131", 9562670),

@MarcoBorrini99
Copy link
Contributor Author

Hello Marco, Very happy to see that you continue to update other engines detection after Adrift ! I think there is a confusion between two games in your Glulx update :

The following entry seems to be linked to the R1 version of "Ein später Besuch" and not to "Der onirische Garten" : DT_ENTRYL1("deronirischegarten", Common::DE_DEU, "r1/190626", "b201ade8eb29a64892cf1370de3c9131", 9562670),

I'll put in the todo list; actually I'm working on zcode detection table and then a second run on glux subsystem will follow (the first one was very very poor).

Meanwhile thanks for noticing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants