CREATE_PROJECT/CI: Support vcpkg integration #4932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a great idea to me. I'll hopefully have some time to test this tomorrow. |
| if (setup.useVcpkg) { | ||
| cmdLine += " "$(VcpkgCurrentInstalledDir)"; | ||
| if (!isRelease) { | ||
| cmdLine += "debug/"; |
There was a problem hiding this comment.
Isn't it missing a / at the beginning?
There was a problem hiding this comment.
VC paths already end in /
But you did make me spot a typo so thanks.
|
Thanks! Let's hope the github Ci is happier now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
--vcpkgflag to create_project to get library dependencies directly from vcpkg instead of SCUMMVM_LIBS. This allows the CI to keep up with the latest vcpkg updates without requiring hacks and workarounds as libraries change (eg. #4648), and allows developers to use the latest library versions instead of pre-compiled if they prefer.(based on the work of #2568)