IMAGE: Speed up 16/24/32bpp BMP decoding #4937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, I think, this could be merged early and then the relevant engines fixed if they were not checking the returned format |
sev-
approved these changes
Apr 29, 2023
|
Okay, merging before it gets bitrot. |
|
FWIW, on an old Loongson 2F mips64el CPU (@ 797 MHz), this PR makes loading the
so nearly a 75% performance improvement! The game now starts much faster there. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most engines already convert the image to the current screen format after loading, so this avoids intermediate conversions and allows reading entire rows in one go.