DIRECTOR: More fixes for D5 #4955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moralrecordings
changed the title
moralrecordings
force-pushed
the
director_v5
branch
2 times, most recently
from
cc25b37 to
7fe471a
Compare
In D5 and up, you can have multiple casts in the same movie, along with external casts. Unlike shared casts these are different namespaces; each movie maps the casts to a libId, which is then used by CastMemberID.castLib. For D4 and below, the default cast libId is now represented by DEFAULT_CAST_LIB. This should make refactoring easier in future.
moralrecordings
force-pushed
the
director_v5
branch
from
7fe471a to
f0c9863
Compare
Previously, the palette ID namespace was shared between cast ID, builtin ID and resource fork ID. This was quite messy. The new approach is to use CastMemberID; builtin palettes are libId -1, cast palettes use their respective libId, and a null CastMemberID indicates a blank entry.
moralrecordings
force-pushed
the
director_v5
branch
from
0a1c892 to
7a55da7
Compare
moralrecordings
force-pushed
the
director_v5
branch
from
a3aa820 to
87a217a
Compare
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.