CREATE_PROJECT: Add --libs-path command line parameter that can be used instead of the SCUMMVM_LIBS environment var #4959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in place of setting the SCUMMVM_LIBS environment var
|
Nice addition! I like the idea, and the implementation is clean and straightforward. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various reasons that it may be undesirable to use an environment variable as part of configuring a build, such as the fact that it requires privilege elevation to set, which can make it more complicated to set up in a new build environment.
This adds a
--libs-pathparameter to create_project that lets you specify the path instead of using the environment variable.