Fix various -Wformat warnings on 32-bit archs #4961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
-Wformatwarnings show up in the build logs of some of our 32-bits ports (such as Android 32 bit, Dreamcast, Debian i686…), when calling a printf-like function with something like%ldand an argument that's not guaranteed to be the same size as alongby default.This is a proposal for fixing this.
The general idea is just to use an explicit cast to
long, since it looks like this is what is done in general in the codebase (?), and AFAICS the impacted engines are for older games with no real-world possibility of 64-bit file offsets, especially for some simple debug output. Casting tolong longis another possibility (which is potentially even better), but I just tried to follow the existing "style" of each component.