IOS7: Implement port specific options widget #4968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
reviewed
May 2, 2023
criezy
reviewed
May 2, 2023
criezy
requested changes
May 2, 2023
larsamannen
force-pushed
the
ls_options_dialog
branch
2 times, most recently
from
54fef28 to
e0c060d
Compare
Include the newly added ios7_options implementation to the project. Change the file type to .mm which is Objective C++ to be able to use the @Availble mechanism. Implement virtual functions and fix build errors in initial code. Also add help section for the tvOS port when building for tvOS. Add ios7_options to POTFILES to get automatic translation on the help section.
These gesture recognizers were inherited from the iphone port. The ios7 port use the UIGestureRecognizers to accomplish the same.
The "touchpad" mode and "click-and-drag" mode was mutual exclusive when enabling "click-and-drag" using swipe gesture. The difference between "touchpad" mode and "click-and-drag" mode is how the button down/up events are sent. In touchpad mode the button down and button up events are sent on touches ended, while in click-and-drag the button down event is sent on touches began and button up on touches ended.
larsamannen
force-pushed
the
ls_options_dialog
branch
from
e0c060d to
2f707ab
Compare
When changing "Touchpad mode" or "Mouse-click-and-drag mode" by swipe gestures, these changes must be stored in ConfMan.
The wrong delegate method was called for touchesCancelled. This led to button presses ended too early if moving the fingers.
Some game engines requires the dpad to control a character. The GRIM engine is an example of this where the user steer the character by the arrow keys or dpad controller.
Apple introduced the GCVirtualController in iOS 15 which is a software emulation of a real controller. The virtual controllers can be configurable with different inputs. See more info at: https://developer.apple.com/documentation/gamecontroller/gcvirtualcontroller A simple gamepad configuration with a dPad and A and B buttons is added. The user can enable/disable the virtual game controller swiping two fingers right to left, or through the port-specific option dialog.
larsamannen
force-pushed
the
ls_options_dialog
branch
from
2f707ab to
c9c05b2
Compare
|
Thanks, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement use of port specific options widget which may be used to enable/disable mouse modes.
Also implement support of Virtual controller (onscreen controls) with one configuration with a dPad and A and B buttons.