KEMBAR78
SAGA2: move call to delayMillis in updatePalette() by spleen1981 · Pull Request #4984 · scummvm/scummvm · GitHub
Skip to content

Conversation

@spleen1981
Copy link
Contributor

Everytime this test fails (actually it does at least when elapsedTime = 0) the engine stucks in an infinite loop if the backend uses calls to g_system methods to call the timer handler.
Moving the call to delayMillis outside the test block solves the issue (provided that the backend uses delayMillis to call the timer handler), as elapsedTime can progress whether interpolated tempPalette is already equal to _currentPalette or not.

@bluegr
Copy link
Member

bluegr commented May 8, 2023

Nice work, thanks!

@bluegr bluegr merged commit fd32607 into scummvm:master May 8, 2023
@spleen1981 spleen1981 deleted the fix_saga2_infinite_loop branch May 14, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants