DIRECTOR: Fix abort with director 6 #4988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sev-
reviewed
May 8, 2023
| bool Cast::loadConfig() { | ||
| Common::SeekableReadStreamEndian *stream = nullptr; | ||
| stream = _castArchive->getMovieResourceIfPresent(MKTAG('V', 'W', 'C', 'F')); | ||
| if (!stream) |
There was a problem hiding this comment.
This is better to be checked against the Director version. E.g. something like if (Director < 6) load VWCF, load DRCF otherwise.
There was a problem hiding this comment.
Original director checks for both judging from the reversing documentation.
sev-
reviewed
May 8, 2023
| fileOffset = _resources[fileId]->offset; | ||
| endianStream.seek(fileOffset + 8); | ||
| uint32 tag = endianStream.readUint32(); | ||
| if (tag != MKTAG('X', 't', 'r', 'a') && tag != MKTAG('a', 'r', 't', 'X')) |
There was a problem hiding this comment.
Since the stream is endian, why checking for different endianness?
There was a problem hiding this comment.
Mostly for safety. They are containers inside of containers so I didn't want to assume that both levelsuse the same endianness
|
Looks good, thank you! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this doesn't add support for D6, only improves error message