Update frame on safe insets changes and update Info.plist with export compliance #4989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition when iOS updates the safe insets and the view is updated on orientation changes. When rotating the device the callback function interfaceOrientationChanged is called. This triggers rebuildSurface to be called, which will call updateOutputSurface, which will trigger initSurface. That function will finally will adjust the main frame towards the safe areas by calling the function adjustViewFrameForSafeArea. But it seems that when adjustViewFrameForSafeArea is called the safe insets values are not updated which will lead to wrong offset values in the frame for touches which will make the mouse pointer inaccurate. The iOS system makes calls to safeAreaInsetsDidChange whenever the safe insets values are updated. Make sure to update the frame on these calls to get correct touch offsets.
Every time ScummVM iOS application is submitted to TestFlight or the App Store, App Store Connect asks a question about the application's export compliance. To not have to answer that question on every upload, set the property ITSAppUsesNonExemptEncryption in Info.plist to NO. ScummVM uses third-party libraries that utilizes encryption, however these are configured to use standard encryption algorithms or crypto functionality within Apple’s operating system, thus fulfilling the export compliance.
criezy
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 commits.
The first one fixes inaccurate touches which was discovered on devices where the frame had to be resized to comply with the safeArea of the screen.
The second commit adds the ITSAppUsesNonExemptEncryption to the Info.plist so we don't have to answer about export compliance every time a new build is submitted.