COMMON: Strip whitespace before checking if an INI line is a comment. #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As one of the users of this class I think the change is probably fine, but it would be nice to also add some test cases to |
Fixes some versions of Reah failing to parse subtitle data.
elasota
force-pushed
the
fix-ini-whitespace
branch
from
a08cfb7 to
913cf80
Compare
|
Nice work! Clean and simple change, and an associated test has been added, too. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on comments from https://bugs.scummvm.org/ticket/14447 it appears that some versions of Reah have lines in the subtitle data which are whitespace followed by a comment. The current code doesn't handle this properly, it only discards whitespace-only, comment-only, and empty lines.